Merge pull request #420 from SciML/blaseltypes

Ensure that BLAS is only called with BLAS element types
SciML · Nov 7, 2023 · b64f2f3 · b64f2f3
2 parents d914caa + 731d332
commit b64f2f3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/LinearSolve.jl b/src/LinearSolve.jl
@@ -112,6 +112,8 @@ struct DefaultLinearSolver <: SciMLLinearSolveAlgorithm
     alg::DefaultAlgorithmChoice.T
 end
 
+const BLASELTYPES = Union{Float32, Float64, ComplexF32, ComplexF64}
+
 include("common.jl")
 include("factorization.jl")
 include("appleaccelerate.jl")

diff --git a/src/default.jl b/src/default.jl
@@ -156,7 +156,7 @@ function defaultalg(A, b, assump::OperatorAssumptions)
         # whether MKL or OpenBLAS is being used
         if (A === nothing && !(b isa GPUArraysCore.AbstractGPUArray)) || A isa Matrix
             if (A === nothing ||
-                eltype(A) <: Union{Float32, Float64, ComplexF32, ComplexF64}) &&
+                eltype(A) <: BLASELTYPES) &&
                ArrayInterface.can_setindex(b) &&
                (__conditioning(assump) === OperatorCondition.IllConditioned ||
                 __conditioning(assump) === OperatorCondition.WellConditioned)
@@ -180,7 +180,8 @@ function defaultalg(A, b, assump::OperatorAssumptions)
                 DefaultAlgorithmChoice.QRFactorization
             elseif __conditioning(assump) === OperatorCondition.SuperIllConditioned
                 DefaultAlgorithmChoice.SVDFactorization
-            elseif usemkl
+            elseif usemkl && (A === nothing ? eltype(b) <: BLASELTYPES :
+                        eltype(A) <: BLASELTYPES)
                 DefaultAlgorithmChoice.MKLLUFactorization
             else
                 DefaultAlgorithmChoice.LUFactorization