Merge pull request #210 from SciML/rk/fix_umfpack

Use new ctor in 1.9
SciML · Oct 20, 2022 · cbbf8d1 · cbbf8d1
2 parents cbeca68 + 28d5b79
commit cbbf8d1
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/src/factorization.jl b/src/factorization.jl
@@ -275,14 +275,17 @@ function init_cacheval(alg::UMFPACKFactorization, A, b, u, Pl, Pr, maxiters::Int
                        verbose::Bool, assumptions::OperatorAssumptions)
     A = convert(AbstractMatrix, A)
     zerobased = SparseArrays.getcolptr(A)[1] == 0
-    res = SuiteSparse.UMFPACK.UmfpackLU(C_NULL, C_NULL, size(A, 1), size(A, 2),
-                                        zerobased ? copy(SparseArrays.getcolptr(A)) :
-                                        SuiteSparse.decrement(SparseArrays.getcolptr(A)),
-                                        zerobased ? copy(rowvals(A)) :
-                                        SuiteSparse.decrement(rowvals(A)),
-                                        copy(nonzeros(A)), 0)
-    finalizer(SuiteSparse.UMFPACK.umfpack_free_symbolic, res)
-    res
+    @static if VERSION < v"1.9.0-DEV.1622"
+        return SuiteSparse.UMFPACK.UmfpackLU(C_NULL, C_NULL, size(A, 1), size(A, 2),
+                                             zerobased ? copy(SparseArrays.getcolptr(A)) :
+                                             SuiteSparse.decrement(SparseArrays.getcolptr(A)),
+                                             zerobased ? copy(rowvals(A)) :
+                                             SuiteSparse.decrement(rowvals(A)),
+                                             copy(nonzeros(A)), 0)
+        finalizer(SuiteSparse.UMFPACK.umfpack_free_symbolic, res)
+    else
+        return SuiteSparse.UMFPACK.UmfpackLU(A)
+    end
 end
 
 function SciMLBase.solve(cache::LinearCache, alg::UMFPACKFactorization; kwargs...)