Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many tweaks to the default algorithm choice #160

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Many tweaks to the default algorithm choice #160

merged 5 commits into from
Jul 18, 2022

Conversation

ChrisRackauckas
Copy link
Member

Summary:

  • RecrusiveFactorization choice looks for Flaot32|Float64 and Julia threads. This should fix the main issue in "Fast" solvers are slow for dense, complex matrix #159 that RFLUFactorization is not optimized on complex matrices
  • CuArrays now supports LU factorizations
  • If a standard matrix, then use FastLUFactorization

That last bit still has a question mark (#159 (comment))

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #160 (ce5c593) into main (2e1b5ed) will increase coverage by 5.30%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   61.41%   66.72%   +5.30%     
==========================================
  Files           9        9              
  Lines         622      622              
==========================================
+ Hits          382      415      +33     
+ Misses        240      207      -33     
Impacted Files Coverage Δ
src/default.jl 69.66% <33.33%> (+24.71%) ⬆️
src/factorization.jl 81.09% <0.00%> (+1.49%) ⬆️
src/common.jl 84.00% <0.00%> (+10.00%) ⬆️
src/LinearSolve.jl 75.00% <0.00%> (+75.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Summary:

- RecrusiveFactorization choice looks for Flaot32|Float64 and Julia threads. This should fix the main issue in #159 that RFLUFactorization is not optimized on complex matrices
- CuArrays now supports LU factorizations
- If a standard matrix, then use FastLUFactorization

That last bit still has a question mark (#159 (comment))
src/default.jl Outdated Show resolved Hide resolved
src/default.jl Outdated Show resolved Hide resolved
@ChrisRackauckas ChrisRackauckas merged commit 8f21ca3 into main Jul 18, 2022
@ChrisRackauckas ChrisRackauckas deleted the defaults branch July 18, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants