Support SciMLOperators in LinearSolve #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, I like the direct ldiv! route. Just needs some clean up and upstream merges first. |
…iagonal matrices are always square.
Codecov Report
@@ Coverage Diff @@
## main #270 +/- ##
===========================================
+ Coverage 38.51% 71.09% +32.57%
===========================================
Files 13 14 +1
Lines 810 858 +48
===========================================
+ Hits 312 610 +298
+ Misses 498 248 -250
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
gotta put |
|
rerunning CI. some tests were cancelled. |
| @@ -4,7 +4,7 @@ using HYPRE.LibHYPRE: HYPRE_Complex | |||
| using HYPRE: HYPRE, HYPREMatrix, HYPRESolver, HYPREVector | |||
| using IterativeSolvers: Identity | |||
| using LinearSolve: HYPREAlgorithm, LinearCache, LinearProblem, LinearSolve, | |||
| OperatorAssumptions, default_tol, init_cacheval, issquare, set_cacheval | |||
| OperatorAssumptions, default_tol, init_cacheval, __issquare, set_cacheval | |||
There was a problem hiding this comment.
we need to be careful with this release.
There was a problem hiding this comment.
yes. good we have CI test for 1.9
There was a problem hiding this comment.
tests passing with lts, release, beta locally.
vpuri3
added a commit
to vpuri3/SciMLBase.jl
that referenced
this pull request
Feb 6, 2023
reexport scimlops now that `issquare` name conflict is fixed in SciML/LinearSolve.jl#270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan: SciML/SciMLOperators.jl#142
Merge these first:
SciML/SciMLBase.jl#377
#269
The changes in the PR are as follows:
AbstractDiffEqOperatorwithAbstractSciMLOperators.DirectLdiv! <: AbstractLinearSolveAlgorithmso that types that have aldiv!defined may skip a second factorization step and simply use theirldiv!. Example, whenA isa Factorization,or aBiDiagonal, or aSciMLOperatorwithhas_ldiv!(A) == true.InvPreconditioner, as it is no longer needed: fill out residual in output stats JuliaSmoothOptimizers/Krylov.jl#612 (comment).ComposePreconditioneras it is used inOrdinaryDiffEqIterativeSolvers.IwithSciMLOperators.IdentityOperator{N}()as identity matrix placeholder. wrote static method_isidentity_structfor checking.TODO's for future changes WRT plan, someOperatorAssumptionsnotes.