Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU tests #388

Merged
merged 14 commits into from
Oct 5, 2023
Merged

Fix GPU tests #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7733608
Fix GPU tests
ChrisRackauckas Oct 4, 2023
9465ede
fix non copy
ChrisRackauckas Oct 4, 2023
50afe93
Remove MKL requires
ChrisRackauckas Oct 4, 2023
6debe9c
Revert "Remove MKL requires"
ChrisRackauckas Oct 4, 2023
affc130
fix GPU test
ChrisRackauckas Oct 4, 2023
9ea818d
simplify gpu code
ChrisRackauckas Oct 4, 2023
ee0ecf1
try simpler gpu code
ChrisRackauckas Oct 4, 2023
6cbe0f2
try qr
ChrisRackauckas Oct 4, 2023
457d67f
namespace
ChrisRackauckas Oct 4, 2023
5455c12
fix imports
ChrisRackauckas Oct 4, 2023
e593c20
fix QR
ChrisRackauckas Oct 5, 2023
21d1b0a
qr in build
ChrisRackauckas Oct 5, 2023
72bb031
fix
ChrisRackauckas Oct 5, 2023
b8ef3e4
fix
ChrisRackauckas Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions ext/LinearSolveCUDAExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,26 @@
module LinearSolveCUDAExt

using CUDA, LinearAlgebra, LinearSolve, SciMLBase
using CUDA
using LinearSolve
using LinearSolve.LinearAlgebra, LinearSolve.SciMLBase, LinearSolve.ArrayInterface
using SciMLBase: AbstractSciMLOperator

function SciMLBase.solve!(cache::LinearSolve.LinearCache, alg::CudaOffloadFactorization;
kwargs...)
if cache.isfresh
fact = LinearSolve.do_factorization(alg, CUDA.CuArray(cache.A), cache.b, cache.u)
cache = LinearSolve.set_cacheval(cache, fact)
fact = qr(CUDA.CuArray(cache.A))
cache.cacheval = fact
cache.isfresh = false
end

copyto!(cache.u, cache.b)
y = Array(ldiv!(cache.cacheval, CUDA.CuArray(cache.u)))
y = Array(ldiv!(CUDA.CuArray(cache.u), cache.cacheval, CUDA.CuArray(cache.b)))
cache.u .= y
SciMLBase.build_linear_solution(alg, y, nothing, cache)
end

function LinearSolve.do_factorization(alg::CudaOffloadFactorization, A, b, u)
A isa Union{AbstractMatrix, AbstractSciMLOperator} ||
error("LU is not defined for $(typeof(A))")

if A isa Union{MatrixOperator, DiffEqArrayOperator}
A = A.A
end

fact = qr(CUDA.CuArray(A))
return fact
function LinearSolve.init_cacheval(alg::CudaOffloadFactorization, A, b, u, Pl, Pr,
maxiters::Int, abstol, reltol, verbose::Bool,
assumptions::OperatorAssumptions)
qr(CUDA.CuArray(A))
end

end
16 changes: 8 additions & 8 deletions test/gpu/cuda.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ function test_interface(alg, prob1, prob2)
@test A1 * y ≈ b1

cache = SciMLBase.init(prob1, alg; cache_kwargs...) # initialize cache
y = solve(cache)
@test A1 * y ≈ b1
solve!(cache)
@test A1 * cache.u ≈ b1

cache = LinearSolve.set_A(cache, copy(A2))
y = solve(cache)
@test A2 * y ≈ b1
cache.A = copy(A2)
solve!(cache)
@test A2 * cache.u ≈ b1

cache = LinearSolve.set_b(cache, b2)
y = solve(cache)
@test A2 * y ≈ b2
cache.b = copy(b2)
solve!(cache)
@test A2 * cache.u ≈ b2

return
end
Expand Down
Loading