Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote abstol and reltol type to match eltype(A) #397

Merged
merged 3 commits into from
Oct 20, 2023
+6 −2
Merged

Promote abstol and reltol type to match eltype(A) #397

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e214453
Promote abstol and reltol type to match eltype(A)
ma-sadeghi Oct 20, 2023
f355271
Update src/common.jl
ChrisRackauckas Oct 20, 2023
4c77e2c
Use prob.b instead of prob.A to promote abstol and reltol in case A i…
ma-sadeghi Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/common.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,10 @@
fill!(u0, false)
end

# Guard against type mismatch for user-specified reltol/abstol
reltol = eltype(prob.A)(reltol)
abstol = eltype(prob.A)(abstol)

Check warning on line 155 in src/common.jl

View check run for this annotation

Codecov / codecov/patch

src/common.jl#L154-L155 

Added lines #L154 - L155 were not covered by tests
ma-sadeghi marked this conversation as resolved.
Show resolved Hide resolved

cacheval = init_cacheval(alg, A, b, u0, Pl, Pr, maxiters, abstol, reltol, verbose,
assumptions)
isfresh = true
Expand Down
Loading