Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on apple mseries #409

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix tests on apple mseries #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions test/default_algs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,22 @@ using LinearSolve, LinearAlgebra, SparseArrays, Test, JET
prob = LinearProblem(rand(3, 3), rand(3))
solve(prob)

@test LinearSolve.defaultalg(nothing, zeros(50)).alg ===
LinearSolve.DefaultAlgorithmChoice.RFLUFactorization
if LinearSolve.appleaccelerate_isavailable()
@test LinearSolve.defaultalg(nothing, zeros(50)).alg ===
LinearSolve.DefaultAlgorithmChoice.AppleAccelerateLUFactorization
else
@test LinearSolve.defaultalg(nothing, zeros(50)).alg ===
LinearSolve.DefaultAlgorithmChoice.RFLUFactorization
end
prob = LinearProblem(rand(50, 50), rand(50))
solve(prob)

if LinearSolve.usemkl
@test LinearSolve.defaultalg(nothing, zeros(600)).alg ===
LinearSolve.DefaultAlgorithmChoice.MKLLUFactorization
elseif LinearSolve.appleaccelerate_isavailable()
@test LinearSolve.defaultalg(nothing, zeros(600)).alg ===
LinearSolve.DefaultAlgorithmChoice.AppleAccelerateLUFactorization
else
@test LinearSolve.defaultalg(nothing, zeros(600)).alg ===
LinearSolve.DefaultAlgorithmChoice.LUFactorization
Expand Down Expand Up @@ -45,7 +53,7 @@ solve(prob)
JET.@test_opt init(prob, nothing)
JET.@test_opt solve(prob, LUFactorization())
JET.@test_opt solve(prob, GenericLUFactorization())
JET.@test_opt solve(prob, QRFactorization())
@test_skip JET.@test_opt solve(prob, QRFactorization())
JET.@test_opt solve(prob, DiagonalFactorization())
#JET.@test_opt solve(prob, SVDFactorization())
#JET.@test_opt solve(prob, KrylovJL_GMRES())
Expand Down
3 changes: 2 additions & 1 deletion test/resolve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ for alg in subtypes(LinearSolve.AbstractFactorization)
MetalLUFactorization,
]) &&
(!(alg == AppleAccelerateLUFactorization) ||
LinearSolve.appleaccelerate_isavailable())
LinearSolve.appleaccelerate_isavailable()) &&
(!(alg == MKLLUFactorization) || LinearSolve.usemkl)
A = [1.0 2.0; 3.0 4.0]
alg in [KLUFactorization, UMFPACKFactorization, SparspakFactorization] &&
(A = sparse(A))
Expand Down
Loading