Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch SimpleGMRES when b is updated #417

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 5, 2023

No description provided.

@avik-pal
Copy link
Member Author

avik-pal commented Nov 5, 2023

@ChrisRackauckas buildkite doesn't seem to be running on PRs

@ChrisRackauckas
Copy link
Member

It only runs on the main package, not on forks

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #417 (d1509e6) into main (a9b5581) will increase coverage by 0.02%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   64.45%   64.48%   +0.02%     
==========================================
  Files          26       26              
  Lines        2068     2078      +10     
==========================================
+ Hits         1333     1340       +7     
- Misses        735      738       +3     
Files Coverage Δ
src/common.jl 90.16% <100.00%> (+0.87%) ⬆️
src/simplegmres.jl 86.56% <40.00%> (-1.70%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@avik-pal
Copy link
Member Author

avik-pal commented Nov 5, 2023

@ChrisRackauckas can you make https://buildkite.com/julialang/linearsolve-dot-jl/builds/1504 public? I am not sure what is failing. It passed locally for me

@ChrisRackauckas
Copy link
Member

Public.

@ChrisRackauckas ChrisRackauckas merged commit fc36891 into SciML:main Nov 6, 2023
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants