Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SuiteSparse #426

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

sharanry
Copy link
Contributor

@sharanry sharanry commented Nov 8, 2023

We remove SuiteSparse as it has now been merged with SparseArrays.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #426 (788ad2f) into main (aaaef4f) will increase coverage by 0.17%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   63.77%   63.94%   +0.17%     
==========================================
  Files          26       26              
  Lines        2098     2097       -1     
==========================================
+ Hits         1338     1341       +3     
+ Misses        760      756       -4     
Files Coverage Δ
src/LinearSolve.jl 89.04% <ø> (-0.15%) ⬇️
src/factorization_sparse.jl 100.00% <ø> (ø)
src/factorization.jl 66.73% <40.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sharanry sharanry marked this pull request as ready for review November 8, 2023 19:13
@sharanry
Copy link
Contributor Author

sharanry commented Nov 8, 2023

@ChrisRackauckas this should be ready to go

@ChrisRackauckas ChrisRackauckas merged commit 1fcf3ab into SciML:main Nov 8, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants