Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle wrapper types over GPU arrays correctly #447

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

avik-pal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@avik-pal avik-pal force-pushed the ap/normal_cholesky_dispatches branch from 2ca3731 to 65d76be Compare December 18, 2023 19:59
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (ada5366) 65.50% compared to head (65d76be) 22.46%.

Files Patch % Lines
src/factorization.jl 6.25% 15 Missing ⚠️
src/default.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #447       +/-   ##
===========================================
- Coverage   65.50%   22.46%   -43.05%     
===========================================
  Files          27       27               
  Lines        2096     2088        -8     
===========================================
- Hits         1373      469      -904     
- Misses        723     1619      +896     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 3b4f4ed into main Dec 18, 2023
9 of 16 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/normal_cholesky_dispatches branch December 18, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants