Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check=false with newest KLU #478

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add check=false with newest KLU #478

merged 3 commits into from
Feb 29, 2024

Conversation

rayegun
Copy link
Collaborator

@rayegun rayegun commented Feb 29, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@rayegun rayegun requested a review from oscardssmith February 29, 2024 01:14
@rayegun
Copy link
Collaborator Author

rayegun commented Feb 29, 2024

Note @oscardssmith that infeasible isn't necessarily a correct retcode for both UMFPACK and KLU. It could be an OOM (I know that's pretty much fatal, but it could be), etc. allowsingular may be a better keyword to use starting in 1.11.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.16%. Comparing base (f97cf52) to head (d8f8c2c).

Files Patch % Lines
src/factorization.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   66.31%   66.16%   -0.16%     
==========================================
  Files          28       28              
  Lines        2203     2202       -1     
==========================================
- Hits         1461     1457       -4     
- Misses        742      745       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rayegun rayegun merged commit 6d51feb into main Feb 29, 2024
14 of 18 checks passed
@rayegun rayegun deleted the rk/klu_checkfalse branch February 29, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants