Keep symbolic expressions as is and minor bugfixes optimization system #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add tests which catch this? |
Vaibhavdixit02
changed the title
Vaibhavdixit02
force-pushed
the
optsysfix
branch
from
a0d1511 to
1ad84a7
Compare
|
Failure is unrelated, something's up with RecursiveArrayTools bounds? |
Co-authored-by: Christopher Rackauckas <[email protected]>
|
There is a circular dependency between SciML/Optimization.jl#636 and this PR so the test won't pass. I'll merge this and finish that one up and then create releases such that both CIs start passing with compat bounds. |
|
That's fine, I am trying to get BifurcationKit to tag so we can at least see nothing else broke. If |
|
Wait, did you run locally? Only seeing 41 seconds of failure isn't a good sign 😅 |
|
Yeah have run it locally. The 41 secs is the RecursiveArrayTools thing I mentioned above, the version doesn't get resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.