Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix observed function generation for systems with inputs #2795

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

AayushSabharwal
Copy link
Member

Close #2794

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Test failure looks real.

@AayushSabharwal
Copy link
Member Author

Downstream failure is an SII bug fixed in SciML/SymbolicIndexingInterface.jl#86

@ChrisRackauckas ChrisRackauckas merged commit 4e84df3 into SciML:master Jun 17, 2024
41 of 44 checks passed
@AayushSabharwal AayushSabharwal deleted the as/obsfn-inputs branch June 17, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_explicit_observed_function no longer handles inputs correctly
2 participants