Implement initialize and finalize for symbolic callbacks #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Oct 29, 2024
|
This looks fine but it introduces test failures? |
|
I looked at the test failures and couldn't figure out the attribution... is there a good way to tell which were broken by this PR vs. were broken beforehand? |
|
Open a PR that just changes whitespace on README called "test master" and compare. When I was last looking, LTS was all working though, but maybe one of @AayushSabharwal's changes in SciMLBase did something there. |
|
The failures are fixed by SciML/SciMLBase.jl#837 |
|
Extension failures are fixed on master |
|
As @AayushSabharwal says the test PR https://github.com/SciML/ModelingToolkit.jl/actions/runs/11582815665 also shows that the tests are currently broken; we could wait on his PR to merge for this one? |
|
Master should be fixed now? Rebase. |
BenChung
force-pushed
the
xalizer-affects
branch
from
95b0ecc to
e1775b9
Compare
BenChung
force-pushed
the
xalizer-affects
branch
from
e1775b9 to
e0e0e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.