Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback reinit (test that #2994 is fixed) #3197

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix callback reinit (test that #2994 is fixed) #3197

wants to merge 5 commits into from
+88 −0

Conversation

BenChung
Copy link
Contributor

@BenChung BenChung commented Nov 12, 2024 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Closes #2994

@BenChung BenChung mentioned this pull request Nov 12, 2024
Open
@ChrisRackauckas
Copy link
Member

Tests failed. Expected? Something needs a release?

@BenChung
Copy link
Contributor Author

Sorta... SciML/DiffEqBase.jl#1102 should cause both tests to pass. Probably just needs a release.

@ChrisRackauckas
Copy link
Member

oh yup that was missing a release due to a bad version bump.

@ChrisRackauckas
Copy link
Member

LoadError: change_t_via_interpolation!: method has not been implemented for the integrator this is with the tags?

@ChrisRackauckas ChrisRackauckas mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in affect codegen
2 participants
@BenChung @ChrisRackauckas