BVProblem with constraints #3323
Merged
+559
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisRackauckas this one should be ready now |
ChrisRackauckas
approved these changes
Feb 10, 2025
|
are we sure those test failures are all unrelated? |
|
It might be DiffEqBase 6.162.1? Just tested some of the broken tests on 6.161.0 locally and they worked. |
|
@ChrisRackauckas is this good to merge now? |
ChrisRackauckas
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #3251. Performance is something like 30x worse than generating the BVProblem using manually-defined f, bc, need to investigate why. Will uncomment the BVDAE solver tests when they get updated to use the same boundary condition format as the others.