Renaming discrete variables during structural simplification (plus refactoring tearing_reassemble)
#3379
+593
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyudu
commented
Feb 10, 2025
…of lowest-order variable
|
@AayushSabharwal @ChrisRackauckas this one is ready to review |
|
I think this looks fine, but I'm not entirely sure what makes this required? |
There was a problem hiding this comment.
Overall the refactor is great for code quality. However, since it's aimed at code quality I've been picky about wanting docstrings for everything. In addition, some parts are not clear or seem to have bugs which need to be fixed. It would also be great to get tests to make sure symbolic indexing works properly for both Shift(t, -1)(x) and x_{k-1} form of variables.
|
This should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Shift(t, 1)(Shift(t, -1)(x(t)). This PR changes it to follow the ODE convention of creating a dummy variablex_{t-1}, such that the equation isShift(t, 1)(x_{t-1}(t))tearing_reassemblehas been chunked a bit. Have added some comments toSystemStructureandTearingStateas well