Merge pull request #11 from SciML/smc/fix

Fix type piracy
SciML · Apr 7, 2024 · 2cd876e · 2cd876e
2 parents d8ece0d + 8cad123
commit 2cd876e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/UDEComponents.jl b/src/UDEComponents.jl
@@ -11,7 +11,6 @@ using ComponentArrays: ComponentArray
 export create_ude_component, multi_layer_feed_forward
 
 include("utils.jl")
-include("hacks.jl") # this should be removed / upstreamed
 
 """
     create_ude_component(n_input = 1, n_output = 1;
@@ -42,4 +41,8 @@ function create_ude_component(n_input = 1,
     return ude_comp
 end
 
+function lazyconvert(T, x::Symbolics.Arr)
+    Symbolics.array_term(convert, T, x, size = size(x))
+end
+
 end
diff --git a/src/hacks.jl b/src/hacks.jl
diff --git a/test/qa.jl b/test/qa.jl
@@ -7,8 +7,7 @@ using JET
     Aqua.find_persistent_tasks_deps(UDEComponents)
     Aqua.test_ambiguities(UDEComponents, recursive = false)
     Aqua.test_deps_compat(UDEComponents)
-    # TODO: fix type piracy in propagate_ndims and propagate_shape
-    Aqua.test_piracies(UDEComponents, broken = true)
+    Aqua.test_piracies(UDEComponents)
     Aqua.test_project_extras(UDEComponents)
     Aqua.test_stale_deps(UDEComponents, ignore = Symbol[])
     Aqua.test_unbound_args(UDEComponents)