general CI improvements #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, let's see if this updates the coverage. I recall that there was additional config needed for the token for latest version of the codecov action, but I don't remember the specifics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
===========================================
+ Coverage 94.44% 100.00% +5.55%
===========================================
Files 3 2 -1
Lines 18 16 -2
===========================================
- Hits 17 16 -1
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
|
Looks like it worked, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SebastianM-C I'm not sure if it has to be
fileorfilesin the codecov part. I think in most SciML repos it is without the s.I'm guessing both are fine, but small chance this will get coverage to update.