improve docstring and interface to PI controller #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 55.31% 55.31%
=======================================
Files 48 48
Lines 1609 1609
=======================================
Hits 890 890
Misses 719 719
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Here: https://github.com/SciML/ModelingToolkitStandardLibrary.jl/pull/230/files#diff-2c628e949fda2edfd7af3ee31fbf986535a6b1e959d92d03be9ca070a4b633aeR209 |
ven-k
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous interface required the user to provide a value of
gainPI.k, now there is an outer parameterkthat forwards to the inner parameter. This makesPIconsistent with the other controller definitions and avoids mentioning the internal implementation detailgainPI.