Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add translational components in the API section #257

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

sathvikbhagavan
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.72%. Comparing base (35a41f7) to head (82f9f58).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #257       +/-   ##
===========================================
- Coverage   54.12%   15.72%   -38.41%     
===========================================
  Files          48       48               
  Lines        1648     1647        -1     
===========================================
- Hits          892      259      -633     
- Misses        756     1388      +632     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Looks like this has docs build failures?

@sathvikbhagavan
Copy link
Member Author

The doc build passes now. It was failing because things like https://github.com/SciML/ModelingToolkitStandardLibrary.jl/blob/main/src/Mechanical/Translational/components.jl#L49 where it treats [m] (optional) in the docstring as a link which is malformed and hence errors. Have to be careful around that.

@sathvikbhagavan
Copy link
Member Author

@ChrisRackauckas, can this be merged?

@ChrisRackauckas ChrisRackauckas merged commit eb42ce2 into SciML:main Mar 3, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants