feat(Translational): add AccelerationSensor #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 54.68% 54.65% -0.04%
==========================================
Files 48 48
Lines 1644 1645 +1
==========================================
Hits 899 899
- Misses 745 746 +1 ☔ View full report in Codecov by Sentry. |
baggepinnen
approved these changes
Feb 5, 2024
sathvikbhagavan
force-pushed
the
sb/accelerometer
branch
from
8f59008 to
73b7b80
Compare
ven-k
approved these changes
Feb 5, 2024
sathvikbhagavan
force-pushed
the
sb/accelerometer
branch
from
73b7b80 to
323a024
Compare
sathvikbhagavan
force-pushed
the
sb/accelerometer
branch
from
323a024 to
1756b53
Compare
|
@ChrisRackauckas, can this be merged? |
Comment on lines
+170
to
+171
| @named sys = ODESystem(eqs, t, [], []; systems = [force, source, mass, acc, acc_output]) | ||
| s = complete(structural_simplify(sys)) |
There was a problem hiding this comment.
I was just following the way other tests are written 😅
|
we will need to mass update that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Adding AccelerationSensor which is particularly useful for measuring acceleration of masses without having to do
force/mass.