Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define isconnection on AnalysisPoint #261

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Define isconnection on AnalysisPoint #261

merged 5 commits into from
Feb 22, 2024

Conversation

YingboMa
Copy link
Member

@YingboMa YingboMa commented Feb 5, 2024

This change is required for SciML/ModelingToolkit.jl#2441

@YingboMa
Copy link
Member Author

This PR should be a part of the MTK V9 update.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (17a231f) 0.00% compared to head (cc61d77) 0.00%.
Report is 11 commits behind head on main.

Files Patch % Lines
src/Blocks/analysis_points.jl 0.00% 7 Missing ⚠️
src/Electrical/Digital/gates.jl 0.00% 6 Missing ⚠️
src/Mechanical/TranslationalPosition/components.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #261   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         35      35           
  Lines       1615    1622    +7     
=====================================
- Misses      1615    1622    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YingboMa
Copy link
Member Author

The test failure seems unrelated.

@YingboMa YingboMa merged commit 8abd6d7 into main Feb 22, 2024
12 of 17 checks passed
@YingboMa YingboMa deleted the myb/ap branch February 22, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant