Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update for compatibility with MTKv9 #271

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

Requires SciML/ModelingToolkit.jl#2480

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 54.12%. Comparing base (2da69d3) to head (27c1a1d).

Files Patch % Lines
src/Blocks/sources.jl 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   62.04%   54.12%   -7.92%     
==========================================
  Files          48       48              
  Lines        1449     1648     +199     
==========================================
- Hits          899      892       -7     
- Misses        550      756     +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

The standard library should all get units, but this is at least a non-breaking update so we can merge this and do the breaking one separately.

@ChrisRackauckas ChrisRackauckas merged commit 4ec8af3 into SciML:main Feb 23, 2024
4 of 9 checks passed
@AayushSabharwal AayushSabharwal deleted the as/mtk-v9 branch February 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants