Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify temperature dependency for analog components #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

langestefan
Copy link
Contributor

@langestefan langestefan commented Dec 23, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This simplifies some of the component definitions, similar to how they are defined in Modelica.

For example, in Modelica the resistor has a useHeatPort boolean argument which adds a temperature dependency.

This means HeatingDiode and HeatingResistor components are removed, but Resistor and Diode now incorporate optional temperature-dependent behavior. By default temperature dependency is disabled, so Resistor(R=1.0) can be called as usual.

@langestefan langestefan marked this pull request as ready for review December 23, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant