Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jacobian Construction for concrete_jac #229

Merged
merged 8 commits into from
Oct 6, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Oct 6, 2023

Needs #226

@avik-pal avik-pal mentioned this pull request Oct 6, 2023
@avik-pal
Copy link
Member Author

avik-pal commented Oct 6, 2023

Needs JuliaDiff/SparseDiffTools.jl#263

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #229 (b5b9298) into master (fd4ae4b) will increase coverage by 1.32%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   93.64%   94.97%   +1.32%     
==========================================
  Files           8        8              
  Lines         771      776       +5     
==========================================
+ Hits          722      737      +15     
+ Misses         49       39      -10     
Files Coverage Δ
src/NonlinearSolve.jl 66.66% <ø> (ø)
src/levenberg.jl 98.48% <100.00%> (+0.77%) ⬆️
src/jacobian.jl 86.79% <50.00%> (-5.05%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 5c89c59 into SciML:master Oct 6, 2023
12 of 16 checks passed
@avik-pal avik-pal deleted the ap/concrete_jac branch October 6, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants