Better Defaults: Auto AD Selection for Newton Methods #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
avik-pal
commented
Oct 17, 2023
•
avik-pal
commented
- Cleanup the Poly Algorithms
- Proper AD Selection
|
did you time it at all? It's completely dynamically dispatching and not type stable. |
|
Yes not ready yet 😓 |
|
I will loop unroll that version to avoid adding sols for if we add anything to the cache later |
avik-pal
changed the title
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 86.05% 93.37% +7.31%
==========================================
Files 14 14
Lines 1205 1147 -58
==========================================
+ Hits 1037 1071 +34
+ Misses 168 76 -92
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Everything is type-stable to the extent that the output alg is a union type. |
avik-pal
changed the title
avik-pal
force-pushed
the
ap/defaults
branch
2 times, most recently
from
03d1e85 to
a5ace21
Compare
|
@ChrisRackauckas this is ready to go in |
ChrisRackauckas
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.