Replace .*(Number, Diagonal) with *(Number, Diagonal)
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result with / without broadcasting here is the same. Removing the broadcast here would avoid JuliaGPU/CUDA.jl#2140. Further, when `cache.DtD.diag isa ComponentVector` that CUDA bug would lead to scalar indexing error on GPU.
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 93.49% 93.20% -0.29%
==========================================
Files 19 19
Lines 1782 1781 -1
==========================================
- Hits 1666 1660 -6
- Misses 116 121 +5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oscardssmith
approved these changes
Nov 1, 2023
|
are the failures related to this PR @avik-pal ? |
|
Rebase this should have been fixed |
avik-pal
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result with / without broadcasting here is the same. Removing the broadcast here would avoid JuliaGPU/CUDA.jl#2140. Further, when
cache.DtD.diag isa ComponentVectorthat CUDA bug leads to scalar indexing error on GPU.