refactor: Move dual nonlinear solving to NonlinearSolveBase #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
reviewed
Dec 3, 2024
|
overall this looks correct, the reason we had this in NonlinearSolve was the Poly algorithms, but now that those have been moved to base, we can safely do this |
|
I believe this PR is ready now. To avoid introducing additional overhead in Base, I put the init and solve dispatch of Dual nonlinear problems in every sub-package extension for ForwardDiff so that different kinds of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #512
Move the solving dispatch for nonlinear problems with u0 or p specified as Dual number to NonlinearSolveBase so that all sub-packages can share this feature.