Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Fixed to allow using matrices as scalar like entity #102

Closed
wants to merge 1 commit into from

Conversation

mauro3
Copy link
Contributor

@mauro3 mauro3 commented Jun 10, 2016

Fixes #86

Note, this drops Julia 0.3 compatibility due to a bug in its norm function (shows up in hinit).

@coveralls
Copy link

coveralls commented Jun 10, 2016

Coverage Status

Coverage decreased (-0.2%) to 93.417% when pulling a599301 on mauro3:m3/fix-matrix-as-scalar into a0ef97d on JuliaLang:master.

@mauro3 mauro3 force-pushed the m3/fix-matrix-as-scalar branch from a599301 to 77cfd6a Compare June 10, 2016 14:14
@codecov-io
Copy link

codecov-io commented Jun 10, 2016

Current coverage is 93.41%

Merging #102 into master will decrease coverage by 0.23%

@@             master       #102   diff @@
==========================================
  Files             2          2          
  Lines           315        319     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            295        298     +3   
- Misses           20         21     +1   
  Partials          0          0          

Powered by Codecov. Last updated by a0ef97d...77cfd6a

@coveralls
Copy link

coveralls commented Jun 10, 2016

Coverage Status

Coverage decreased (-0.2%) to 93.417% when pulling 77cfd6a on mauro3:m3/fix-matrix-as-scalar into a0ef97d on JuliaLang:master.

@mauro3 mauro3 changed the title Fixed to allow using martices as scalar like entity Fixed to allow using matrices as scalar like entity Jun 24, 2016
@mauro3
Copy link
Contributor Author

mauro3 commented Jun 24, 2016

Would be great if someone could review this! @obiajulu and @pwl are currently working on things which could use this (well at least the test case).

@ChrisRackauckas
Copy link
Member

This seems like a way of fitting everything into the Vector format (and forcing Vector{Vector} output), instead of directly handling AbstractArrays (and outputing Vector{AbstractArray}). What's the reason for this decision?

@mauro3
Copy link
Contributor Author

mauro3 commented Sep 2, 2016

Yes, we (also @pwl) should discuss the best approach sometime soon.

@mauro3 mauro3 closed this May 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants