-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map maxiters
to outer_iterations
#544
Conversation
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=========================================
- Coverage 8.87% 2.16% -6.71%
=========================================
Files 40 40
Lines 2669 2673 +4
=========================================
- Hits 237 58 -179
- Misses 2432 2615 +183
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
is it always outer iterations or only when it's fminbox? |
ah, good point. should it be |
I think so, and this needs a test |
We should actually switch to using both |
@SebastianM-C you might want to pull and rebase, sorry! 😅 |
Is this ready to go? |
I think it should be fine now. |
Will merge once Optim tests pass, thanks! |
Fix #508
I implemented #508 (comment) here, but I'm not sure how to test it.
cc @Vaibhavdixit02 @ChrisRackauckas