[WIP] Ensemble #620
[WIP] Ensemble #620
Conversation
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=========================================
+ Coverage 2.85% 8.25% +5.39%
=========================================
Files 40 41 +1
Lines 2694 2714 +20
=========================================
+ Hits 77 224 +147
+ Misses 2617 2490 -127
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/ensemble.jl
Outdated
| end | ||
|
|
||
| function SciMLBase.__solve(caches::Vector{OptimizationCache}, args...; kwargs...) | ||
| function SciMLBase.__init(prob::EnsembleProblem{T}, args...; trajectories, kwargs...) where {T <: OptimizationProblem} |
There was a problem hiding this comment.
this is missing all of the ensemblealgs.
| @@ -3,6 +3,16 @@ function SciMLBase.EnsembleProblem(prob::OptimizationProblem, u0s::Vector{Vector | |||
| return SciMLBase.EnsembleProblem(prob; prob_func, kwargs...) | |||
| end | |||
|
|
|||
| function SciMLBase.EnsembleProblem(prob::OptimizationProblem, trajectories::Int; kwargs...) | |||
There was a problem hiding this comment.
I'd just keep to the interface. This doesn't seem like a necessary shorthand to me.
There was a problem hiding this comment.
I'd like to provide an automated way of doing the solves with initial points sampled, it would be useful. I can probably do it another way if you are opposed to this, but do note that the other dispatch is already not conforming fully with the current interface of creating these problems
There was a problem hiding this comment.
it would be good to come up with such a shorthand at a higher level of the interface, since NonlinearProblem, NonlinearLeastSquaresProblem, etc. would want to do similar things.
|
superseeded by SciML/SciMLBase.jl#538 |
No description provided.