Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqua + typos CI #639

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Aqua + typos CI #639

merged 2 commits into from
Dec 2, 2023

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c178ba0) 0.00% compared to head (d893727) 7.74%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #639      +/-   ##
=========================================
+ Coverage    0.00%   7.74%   +7.74%     
=========================================
  Files          12      40      +28     
  Lines        1141    2699    +1558     
=========================================
+ Hits            0     209     +209     
- Misses       1141    2490    +1349     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArnoStrouwen
Copy link
Member Author

I'm guessing putting a compat for a weakdep is not backwards compatible with 1.6?

@Vaibhavdixit02
Copy link
Member

Looks like it yeah. We could add the packages, also to the extras but it doesn't feel nice to do it 😅

@ArnoStrouwen
Copy link
Member Author

Can we just up the Julia compat to 1.8 or 1.9? e.g. NonlinearSolve has done so aswell.

@ChrisRackauckas
Copy link
Member

Bump to v1.9

@ChrisRackauckas ChrisRackauckas merged commit c87416b into SciML:master Dec 2, 2023
24 of 26 checks passed
@ArnoStrouwen ArnoStrouwen deleted the qa branch December 2, 2023 16:42
@sethaxen
Copy link
Contributor

Was it really necessary to drop support for 3 Julia versions including the LTS? Optimization has 38 direct dependents. For those packages to e.g. support the new callback signature, they now need to drop support for all of those versions. Was the only reason for doing this to avoid adding the packages also to [extras]? That's the documented approach: https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)

@ChrisRackauckas
Copy link
Member

v1.10 will be the new LTS, so it's not dropping the LTS

@sethaxen
Copy link
Contributor

v1.10 will be the new LTS

Is this documented somewhere? I couldn't find any statement or timeline on this.

so it's not dropping the LTS

Well, it already did drop the LTS and quite a few other versions, until there's a new one.

@ChrisRackauckas
Copy link
Member

Are you volunteering to do that support for all of the SciML packages for the previous LTS (v1.6)? Our expectations are generally to have answers for each related question within about 12 hours and any major bugfixes within the week. Please let me know if you're willing to take on getting everything to support v1.6 down. I suspect it's about 40 hours to start given the requirements on NonlinearSolve.jl and LinearSolve.jl due to the LinearAlgebra changes in Base which have been substantial, then about 4 hours a week level of commitment. Usually we don't assume a new volunteer who hasn't done such contributions will suddenly take on that level of effort but if you're willing to do it I can show you where to start.

@ArnoStrouwen
Copy link
Member Author

@sethaxen it has not been announced yet. From what I understand, the final decision on LTS will not be made until Julia 1.11 is out. But it is very likely 1.10 will be the new LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants