-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Stats and State #652
[WIP]Stats and State #652
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
=========================================
+ Coverage 8.46% 8.70% +0.24%
=========================================
Files 30 31 +1
Lines 2470 2504 +34
=========================================
+ Hits 209 218 +9
- Misses 2261 2286 +25 ☔ View full report in Codecov by Sentry. |
Maybe it's time for a new design of the arguments list? |
57d6266
to
bf77f69
Compare
@Vaibhavdixit02 The changes to most of the integration packages are marked as breaking, but there's no description for me to know whether it is safe to upgrade. Would it be possible to summarize what this PR does and in what way it is breaking? |
@sethaxen sure, it was breaking because the callback arguments have changed, instead of the optimization variables as the first argument now it will be a |
Thanks, @Vaibhavdixit02 ! |
We need to add a note on the README |
Since this was a breaking change, shouldn't this have required a major version bump? |
It did get a major IIRC |
Optimization.jl didn't get a major version bump, but the backends did get a minor bump (since they are 0.x). |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.