Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra @shows #678

Merged
merged 1 commit into from
Jan 11, 2024
Merged

remove extra @shows #678

merged 1 commit into from
Jan 11, 2024

Conversation

SebastianM-C
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Hi! I think the latest release left some @shows.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4192d89) 1.94% compared to head (07122e9) 8.89%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #678      +/-   ##
=========================================
+ Coverage    1.94%   8.89%   +6.95%     
=========================================
  Files          31      31              
  Lines        2518    2517       -1     
=========================================
+ Hits           49     224     +175     
+ Misses       2469    2293     -176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vaibhavdixit02 Vaibhavdixit02 merged commit f2001e9 into SciML:master Jan 11, 2024
42 of 43 checks passed
@Vaibhavdixit02
Copy link
Member

Shit that shouldn't have made it through. Thanks for taking care of this!

@SebastianM-C SebastianM-C deleted the no_show branch January 11, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants