-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #683: error when store_trace=true
in OptimizationEvolutionary.jl
#691
Conversation
Fixed `store_trace=true` bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
======================================
Coverage 8.62% 8.62%
======================================
Files 31 31
Lines 2515 2515
======================================
Hits 217 217
Misses 2298 2298 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for the error you had seen before?
Will do! |
…ror on origin master.
Fix store_trace=true bug. Test added that should fail on current origin master but pass now.
@Vaibhavdixit02 added a test which fails on current version but passes on my fork. Error "type Array has no field value" was thrown prior to my fix. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Connected to issue #683 (comment)