deepcopy
to save population in default trace, instead of reference
#730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default
trace!
overload was saving population by referencetrace!
overload compat. Bothx
and user records now saved #702 was actually saving a reference topopulation
intrace["x"]
, which was not the intention.deepcopy
fixes the issueThis test fails with the old code, but passes with
deepcopy
:Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.