Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __loss function for MOO using OptimizationMetaheuristics.jl #805

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

ParasPuneetSingh
Copy link
Collaborator

Loss function updated to handle MOO.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Loss function updated to handle MOO.
Added tests for MOO algorithms.
Corrected the objectives dictionary values.
Updated the objective values in the testset for MOO.
Added seed as the objectives were stochastic in nature for MOO.
Copy link
Member

@Vaibhavdixit02 Vaibhavdixit02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it needs Random added to the Project.toml of OptimizationMetaheuristics.jl

@ParasPuneetSingh
Copy link
Collaborator Author

Looks like it needs Random added to the Project.toml of OptimizationMetaheuristics.jl

The Project.toml has been updated but the Cl is still failing:

@Vaibhavdixit02
Copy link
Member

@Vaibhavdixit02
Copy link
Member

@ParasPuneetSingh some test values don't match can you take a look

Increased tolerance from 0.1 to 0.95
@Vaibhavdixit02 Vaibhavdixit02 merged commit 6ecd588 into SciML:master Aug 30, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants