Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dependency on Pkg #807

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

SebastianM-C
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

I don't think Pkg is needed anymore in the package. It is only used in check_pkg_version, but that function isn't public API and not used by anything as far as I can tell. If the functionality is still needed, then Base.pkgversion can be used.

help?> Base.pkgversion
  pkgversion(m::Module)

  Return the version of the package that imported module m, or nothing if m was not imported from a package, or imported from a package without a version field set.

  The version is read from the package's Project.toml during package load.

  To get the version of the package that imported the current module the form pkgversion(@__MODULE__) can be used.

  │ Julia 1.9
  │
  │  This function was introduced in Julia 1.9.

@ChrisRackauckas ChrisRackauckas merged commit 4d4c78a into SciML:master Aug 22, 2024
22 of 26 checks passed
@SebastianM-C SebastianM-C deleted the rm_pkg branch August 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants