-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added precompilation for nonnegative least squares #809
Conversation
Note that if you really just need NonlinearLeastSquaresProblem, the things in NonlinearSolve.jl will be faster. We need to document that better. |
Thanks for the suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the project toml
Just updated it, sorry forgot to do that previously. |
Looks good. @Vaibhavdixit02 is that a failure on master? |
@arismavridis could you post the flamegraphs you had put on discourse here as well. Will merge this soon but wanted to get a better understanding of the improvements, also did you run timings for the example you had that triggered this? |
This is the precompilation for 4x4 matrix: and this is for 35x35 (with 4x4 already precompiled): As for timings, do you mean before and after precompilation?
|
Please refer to discourse post:
https://discourse.julialang.org/t/excessively-long-ttfx-with-optimization-and-optimizationoptimjl/118457/7
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.