Merge pull request #2430 from ParamThakkar123/Fixes6

Perform step refactor for rosenbrock
SciML · Sep 1, 2024 · 1eef9db · 1eef9db
2 parents 04a7c58 + bd9ec06
commit 1eef9db
Show file tree

Hide file tree

Showing 8 changed files with 366 additions and 882 deletions.
diff --git a/lib/OrdinaryDiffEqDifferentiation/src/alg_utils.jl b/lib/OrdinaryDiffEqDifferentiation/src/alg_utils.jl
@@ -76,4 +76,4 @@ end
 @generated function pick_static_chunksize(::Val{chunksize}) where {chunksize}
     x = ForwardDiff.pickchunksize(chunksize)
     :(Val{$x}())
-end
+end
diff --git a/lib/OrdinaryDiffEqDifferentiation/src/derivative_utils.jl b/lib/OrdinaryDiffEqDifferentiation/src/derivative_utils.jl
@@ -12,7 +12,7 @@ struct StaticWOperator{isinv, T, F} <: AbstractSciMLOperator{T}
             # doing to how StaticArrays and StaticArraysCore are split up
             StaticArrays.LU(LowerTriangular(W), UpperTriangular(W), SVector{n}(1:n))
         else
-            lu(W, check = false)
+            lu(W, check=false)
         end
         # when constructing W for the first time for the type
         # inv(W) can be singular
@@ -938,28 +938,28 @@ function LinearSolve.init_cacheval(
 end
 
 for alg in [LinearSolve.AppleAccelerateLUFactorization,
-    LinearSolve.BunchKaufmanFactorization,
-    LinearSolve.CHOLMODFactorization,
-    LinearSolve.CholeskyFactorization,
-    LinearSolve.CudaOffloadFactorization,
-    LinearSolve.DiagonalFactorization,
-    LinearSolve.FastLUFactorization,
-    LinearSolve.FastQRFactorization,
-    LinearSolve.GenericFactorization,
-    LinearSolve.GenericLUFactorization,
-    LinearSolve.KLUFactorization,
-    LinearSolve.LDLtFactorization,
-    LinearSolve.LUFactorization,
-    LinearSolve.MKLLUFactorization,
-    LinearSolve.MetalLUFactorization,
-    LinearSolve.NormalBunchKaufmanFactorization,
-    LinearSolve.NormalCholeskyFactorization,
-    LinearSolve.QRFactorization,
-    LinearSolve.RFLUFactorization,
-    LinearSolve.SVDFactorization,
-    LinearSolve.SimpleLUFactorization,
-    LinearSolve.SparspakFactorization,
-    LinearSolve.UMFPACKFactorization]
+             LinearSolve.BunchKaufmanFactorization,
+             LinearSolve.CHOLMODFactorization,
+             LinearSolve.CholeskyFactorization,
+             LinearSolve.CudaOffloadFactorization,
+             LinearSolve.DiagonalFactorization,
+             LinearSolve.FastLUFactorization,
+             LinearSolve.FastQRFactorization,
+             LinearSolve.GenericFactorization,
+             LinearSolve.GenericLUFactorization,
+             LinearSolve.KLUFactorization,
+             LinearSolve.LDLtFactorization,
+             LinearSolve.LUFactorization,
+             LinearSolve.MKLLUFactorization,
+             LinearSolve.MetalLUFactorization,
+             LinearSolve.NormalBunchKaufmanFactorization,
+             LinearSolve.NormalCholeskyFactorization,
+             LinearSolve.QRFactorization,
+             LinearSolve.RFLUFactorization,
+             LinearSolve.SVDFactorization,
+             LinearSolve.SimpleLUFactorization,
+             LinearSolve.SparspakFactorization,
+             LinearSolve.UMFPACKFactorization]
     @eval function LinearSolve.init_cacheval(alg::$alg, A::WOperator, b, u, Pl, Pr,
             maxiters::Int, abstol, reltol, verbose::Bool,
             assumptions::OperatorAssumptions)
@@ -1003,4 +1003,4 @@ function resize_J_W!(cache, integrator, i)
     end
 
     nothing
-end
+end
diff --git a/lib/OrdinaryDiffEqRosenbrock/src/interp_func.jl b/lib/OrdinaryDiffEqRosenbrock/src/interp_func.jl
@@ -12,7 +12,7 @@ function DiffEqBase.interp_summary(::Type{cacheType},
         dense::Bool) where {
         cacheType <:
         Union{Rodas4ConstantCache, Rodas23WConstantCache, Rodas3PConstantCache,
-        Rodas4Cache, Rodas23WCache, Rodas3PCache}}
+        RosenbrockCache, Rodas23WCache, Rodas3PCache}}
     dense ? "specialized 3rd order \"free\" stiffness-aware interpolation" :
     "1st order linear"
 end