Merge pull request #2516 from AayushSabharwal/as/symbolic-save-idxs

refactor: use `SciMLBase.get_save_idxs_and_saved_subsystem`

lib/OrdinaryDiffEqCore/Project.toml

@@ -70,7 +70,7 @@ Random = "<0.0.1, 1"
 RecursiveArrayTools = "2.36, 3"
 Reexport = "1.0"
 SafeTestsets = "0.1.0"
-SciMLBase = "2.57.2"
+SciMLBase = "2.59.2"
 SciMLOperators = "0.3"
 SciMLStructures = "1"
 SimpleUnPack = "1"

lib/OrdinaryDiffEqCore/src/solve.jl

@@ -264,29 +264,7 @@ function DiffEqBase.__init(
     end
 
     ### Algorithm-specific defaults ###
-    if save_idxs === nothing
-        saved_subsystem = nothing
-    else
-        if !(save_idxs isa AbstractArray) || symbolic_type(save_idxs) != NotSymbolic()
-            _save_idxs = [save_idxs]
-        else
-            _save_idxs = save_idxs
-        end
-        saved_subsystem = SciMLBase.SavedSubsystem(prob, parameter_values(prob), _save_idxs)
-        if saved_subsystem !== nothing
-            _save_idxs = SciMLBase.get_saved_state_idxs(saved_subsystem)
-            if isempty(_save_idxs)
-                # no states to save
-                save_idxs = Int[]
-            elseif !(save_idxs isa AbstractArray) || symbolic_type(save_idxs) != NotSymbolic()
-                # only a single state to save, and save it as a scalar timeseries instead of
-                # single-element array
-                save_idxs = only(_save_idxs)
-            else
-                save_idxs = _save_idxs
-            end
-        end
-    end
+    save_idxs, saved_subsystem = SciMLBase.get_save_idxs_and_saved_subsystem(prob, save_idxs)
 
     if save_idxs === nothing
         ksEltype = Vector{rateType}