Merge pull request #2202 from SciML/initialize_size

Fix initialization size to not try/catch
SciML · May 20, 2024 · 6d35d93 · 6d35d93
2 parents 6a6efe5 + aa02da7
commit 6d35d93
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/OrdinaryDiffEq.jl b/src/OrdinaryDiffEq.jl
@@ -108,7 +108,7 @@ import ADTypes: AbstractADType,
 import Polyester
 using MacroTools, Adapt
 
-using SciMLStructures: canonicalize, Tunable
+using SciMLStructures: canonicalize, Tunable, isscimlstructure
 
 const CompiledFloats = Union{Float32, Float64,
     ForwardDiff.Dual{

diff --git a/src/initialize_dae.jl b/src/initialize_dae.jl
@@ -528,9 +528,10 @@ function _initialize_dae!(integrator, prob::ODEProblem,
     if isAD
         csize = count(algebraic_vars)
         if !(p isa SciMLBase.NullParameters) && typeof(_u) !== typeof(u)
-            try
+            if isscimlstructure(p)
                 csize = max(csize, length(canonicalize(Tunable(), p)[1]))
-            catch
+            else
+                csize = max(csize, length(p))
             end
         end
         chunk = ForwardDiff.pickchunksize(csize)