Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docstring of BS3 #2069

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix docstring of BS3 #2069

merged 2 commits into from
Nov 21, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Nov 21, 2023

Closes #2068

I copied the first sentence of the old docstring in

OrdinaryDiffEq.jl/src/algorithms.jl

Lines 4256 to 4262 in b50390f

"""
BS3(; stage_limiter! = OrdinaryDiffEq.trivial_limiter!,
step_limiter! = OrdinaryDiffEq.trivial_limiter!,
thread = OrdinaryDiffEq.False())
A third-order, four-stage explicit FSAL Runge-Kutta method with embedded error
estimator of Bogacki and Shampine.

@ranocha ranocha requested a review from oscardssmith November 21, 2023 06:27
@ChrisRackauckas
Copy link
Member

oh oops thanks for finding this.

@ChrisRackauckas ChrisRackauckas merged commit 31cf44b into master Nov 21, 2023
58 of 59 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ranocha-patch-1 branch November 21, 2023 10:52
@ChrisRackauckas
Copy link
Member

@avik-pal things are back to green!

@ChrisRackauckas ChrisRackauckas mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscardssmith oscardssmith Awaiting requested review from oscardssmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BS3 docs document OwrenZen5 instead
2 participants
@ranocha @ChrisRackauckas