Remove uses of NLsolve #2081
Merged
Remove uses of NLsolve #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/nlsolve_break
branch
from
0a6fe51 to
f45e837
Compare
avik-pal
commented
Dec 12, 2023
avik-pal
force-pushed
the
ap/nlsolve_break
branch
2 times, most recently
from
14d5263 to
668129a
Compare
|
failures seem to be same as master |
| @@ -564,7 +563,7 @@ function _initialize_dae!(integrator, prob::DAEProblem, | |||
| if alg.nlsolve !== nothing | |||
| nlsolve = alg.nlsolve | |||
| else | |||
| nlsolve = NewtonRaphson(autodiff = isAD) | |||
| nlsolve = NewtonRaphson(autodiff = alg_autodiff(integrator.alg)) | |||
There was a problem hiding this comment.
We should keep it as type information now that we can use it effectively.
There was a problem hiding this comment.
What does alg_autodiff give? Can it give bool?
There was a problem hiding this comment.
Yes it changes the type level stuff to a bool as backwards compat support IIRC
There was a problem hiding this comment.
function alg_autodiff(alg)
autodiff = _alg_autodiff(alg)
if autodiff == Val(false)
return AutoFiniteDiff()
elseif autodiff == Val(true)
return AutoForwardDiff()
else
return _unwrap_val(autodiff)
end
endThis should constant propagate and give the correct AD type right?
There was a problem hiding this comment.
We shouldn't rely on constant propagation. It can fail. But let's pull this in and make this better in a follow up.
ChrisRackauckas
force-pushed
the
ap/nlsolve_break
branch
from
668129a to
9226ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.