Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New methods Rodas23W / Rodas3P with error test for interpolation, see issue 2054 https://github.com/SciML/OrdinaryDiffEq.jl/issues/2054 #2092

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

gstein3m
Copy link
Contributor

Checklist

  • [ x] Appropriate tests were added: wp precision benchmarks were successful
  • [x ] Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • [ x] The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Still needs tests?

@ChrisRackauckas
Copy link
Member

Wow, that was fast. Christmas came early! Looks like this needs tests. @oscardssmith maybe you might want to setup a few benchmarks? I know you have cases you were looking at.

@gstein3m
Copy link
Contributor Author

gstein3m commented Dec 25, 2023 via email

@oscardssmith
Copy link
Contributor

Is this ready to merge?

@gstein3m
Copy link
Contributor Author

Is this ready to merge?

From my point of view, yes.

@ChrisRackauckas
Copy link
Member

Can you rebase onto latest master? I think that should fix up the tests on the Buildkite and everything should be green here.

@ChrisRackauckas ChrisRackauckas merged commit 90a4bf6 into SciML:master Jan 19, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants