Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Low Storage RK methods #2256

Merged
merged 56 commits into from
Jun 26, 2024
Merged

Added Low Storage RK methods #2256

merged 56 commits into from
Jun 26, 2024

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Solves a part of #2177

@ParamThakkar123 ParamThakkar123 mentioned this pull request Jun 23, 2024
Merged
5 tasks
@ChrisRackauckas
Copy link
Member

Rebase onto the new master.

@ParamThakkar123
Copy link
Contributor Author

image

A IRKC undef error in controllers.jl. I defined IRKC on ordinaryDiffEq on line 245 in the way above. And in controllers.jl:

image

@ParamThakkar123
Copy link
Contributor Author

image

Here it shows IRKC is not defined but I have imported it in controllers.jl

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas @ranocha All the UnDef errors are now fixed. Now, There are some errors related to dimension mismatch, precision and method loading. How can I fix this ??

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas Any changes to make??

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas Should I start working on the other solvers as well ?? Simultaneously

@ChrisRackauckas
Copy link
Member

yes just make sure to branch first. It looks like you're working on your fork's master here.

@ParamThakkar123
Copy link
Contributor Author

ParamThakkar123 commented Jun 26, 2024 •
edited
Loading

Yes. I was working in my fork's master. I will sync it with the upstream and also make do the branching

@ChrisRackauckas ChrisRackauckas merged commit 94c0cb4 into SciML:master Jun 26, 2024
24 of 33 checks passed
@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas I started a new PR for SSPRK methods: #2264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

@ranocha ranocha Awaiting requested review from ranocha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ParamThakkar123 @ChrisRackauckas @ranocha