Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DAE solvers #2292

Merged
merged 49 commits into from
Jul 27, 2024
Merged

Added DAE solvers #2292

merged 49 commits into from
Jul 27, 2024

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
solves a part of #2177

@ParamThakkar123 ParamThakkar123 mentioned this pull request Jul 23, 2024
Merged
5 tasks
@ChrisRackauckas
Copy link
Member

Looks like this has merge issues. And the DAE things here are just BDF. This should just be combined with the other bdf

@ParamThakkar123
Copy link
Contributor Author

Looks like this has merge issues. And the DAE things here are just BDF. This should just be combined with the other bdf

So what approach should I follow to tackle this ??

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas Then should I put all the DAE algorithms with the BDF ones ??

@ChrisRackauckas
Copy link
Member

Yes

@ChrisRackauckas
Copy link
Member

Rebase this onto master

@ParamThakkar123
Copy link
Contributor Author

ParamThakkar123 commented Jul 27, 2024 •
edited
Loading

@ChrisRackauckas There's a compute_step!() method failure occurring here. How can we deal with this ?? This occurred after rebase

@ChrisRackauckas ChrisRackauckas merged commit 5a3b4e4 into SciML:master Jul 27, 2024
11 of 35 checks passed
@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas I started a new PR for QPRK solvers #2301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ParamThakkar123 @ChrisRackauckas