-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added High Order and Low Order RK methods #2304
Merged
Merged
Changes from 4 commits
Commits
Show all changes
139 commits
Select commit
Hold shift + click to select a range
3917a26
Added High Order and Low Order RK methods
ParamThakkar123 e7b8f53
Changes
ParamThakkar123 2ad688f
Changes
ParamThakkar123 5d7759a
Update lib/OrdinaryDiffEqLowOrderRK/test/runtests.jl
ChrisRackauckas 235027d
Fixes
ParamThakkar123 0e74476
Update test/runtests.jl
ParamThakkar123 38c83ea
Merge branch 'master' of https://github.com/ParamThakkar123/OrdinaryD…
ParamThakkar123 e852f01
OrdinaryDiffEqTsit5 added
ParamThakkar123 f21324d
added interpolants
ParamThakkar123 aa889f2
trivial_limiter!
ParamThakkar123 fa5c07a
trivial_limiter!
ParamThakkar123 54be923
trivial_limiter!
ParamThakkar123 05a8df5
explicit_rk_docstring
ParamThakkar123 9209566
changes
ParamThakkar123 1756924
changes
ParamThakkar123 4dd3814
changes
ParamThakkar123 135b5af
Fixes
ParamThakkar123 b71cb79
TruncatedStacktraces
ParamThakkar123 56e59f9
@cache
ParamThakkar123 e86154e
trivial_limiter!
ParamThakkar123 475e4ec
Update algorithms.jl
ChrisRackauckas 3432c11
@fold
ParamThakkar123 8f70743
Update lib/OrdinaryDiffEqTsit5/src/OrdinaryDiffEqTsit5.jl
ChrisRackauckas e9dda02
DiffEqBase
ParamThakkar123 00e95a9
@OnDemandTableauExtract
ParamThakkar123 cd7dc0e
trivial_limiter!
ParamThakkar123 3075609
trivial_limiter!
ParamThakkar123 c8cc3cc
CompiledFloats
ParamThakkar123 85d27e3
DiffEqBase
ParamThakkar123 4b0f31b
@cache
ParamThakkar123 b898c57
CompiledFloats
ParamThakkar123 cbf6463
DP8ConstantCache
ParamThakkar123 b5854c6
DiffEqBase
ParamThakkar123 20c62f4
FunctionMap
ParamThakkar123 cd9d69c
FunctionMap
ParamThakkar123 04b47ea
FunctionMapConstantCache
ParamThakkar123 d5cd505
Fixes
ParamThakkar123 64c7100
Interpolants
ParamThakkar123 c5eccec
@tight_loop_macros
ParamThakkar123 7908b40
OrdinaryDiffEqFunctionMap
ParamThakkar123 642810e
FunctionMap
ParamThakkar123 0de6d31
fixes
ParamThakkar123 39c81df
OrdinaryDiffEqConstantCache
ParamThakkar123 f50c16b
OrdinaryDiffEqConstantCache
ParamThakkar123 561bc9e
solve.jl
ParamThakkar123 ec2ed26
Added Adams-Bashforth-Moulton methods
ParamThakkar123 822fd9e
imports
ParamThakkar123 19a48d9
Fixes
ParamThakkar123 a6c9c28
Fixes
ParamThakkar123 fd3f786
Fixes
ParamThakkar123 6463da2
Added Nordsieck solvers
ParamThakkar123 0ddeccc
Added Nordsieck solvers
ParamThakkar123 0117bf1
Setup traits to remove FunctionMap from internals
ChrisRackauckas 905291d
Update lib/OrdinaryDiffEqLowOrderRK/src/OrdinaryDiffEqLowOrderRK.jl
ChrisRackauckas 50ac81c
Added Rosenbrock solvers
ParamThakkar123 5691c0d
Fixes
ParamThakkar123 2ad25d1
Fixes and added Explicit RK solvers
ParamThakkar123 a4226ea
fixes
ParamThakkar123 972426f
Updates
ParamThakkar123 6173202
Update
ParamThakkar123 3f94372
Update src/OrdinaryDiffEq.jl
ChrisRackauckas f51491e
Update OrdinaryDiffEq.jl
ChrisRackauckas de8e503
Update lib/OrdinaryDiffEqRosenbrock/src/OrdinaryDiffEqRosenbrock.jl
ChrisRackauckas 65e5459
Updates
ParamThakkar123 72cfebb
fixes
ParamThakkar123 2c022ad
OrdinaryDiffEqRosenbrockAlgorithm
ParamThakkar123 6529ee1
@ROS2
ParamThakkar123 26f4067
@capture
ParamThakkar123 2dc43ec
Merge remote-tracking branch 'origin/master'
ChrisRackauckas f8dbed2
a bunch of fixes
ChrisRackauckas 3aaceb7
a few more imports
ChrisRackauckas 85e9653
more imports
ChrisRackauckas efc9279
some more imports
ChrisRackauckas b61de14
add missing dep
ChrisRackauckas e610400
more
ChrisRackauckas 02a3bda
more
ChrisRackauckas b35e28e
more
ChrisRackauckas 09ee697
should be the last one
ChrisRackauckas e06f6e5
more imports
ChrisRackauckas 00897fe
next tests...
ChrisRackauckas 6731f9b
update
ParamThakkar123 cc07cf9
copyat_or_push!
ParamThakkar123 d5aad61
calculate_residuals
ParamThakkar123 032368d
Update
ParamThakkar123 2fb92d6
move around some interface functions
ChrisRackauckas 57d61e0
constvalue
ParamThakkar123 19ffbaf
a few more
ChrisRackauckas c5de013
Merge branch 'master' of https://github.com/ParamThakkar123/OrdinaryD…
ChrisRackauckas a0821ff
Update src/solve.jl
ChrisRackauckas 59e4a26
jacobian2W!
ParamThakkar123 3fcefb1
more
ChrisRackauckas dd78907
Merge branch 'master' of https://github.com/ParamThakkar123/OrdinaryD…
ChrisRackauckas 6648d8a
another
ChrisRackauckas 8df87e6
deps in ABM
ChrisRackauckas 4752f18
import correctly
ChrisRackauckas 4ff49d9
Fix ABM import
ChrisRackauckas dd497b8
RK4Cache
ParamThakkar123 2c5e729
Update src/solve.jl
ChrisRackauckas c722380
add missing imports
ChrisRackauckas e3e16ae
Merge branch 'master' of https://github.com/ParamThakkar123/OrdinaryD…
ChrisRackauckas ec264c0
@def
ParamThakkar123 f7e492f
some clean up
ChrisRackauckas 2c85152
fix project toml
ChrisRackauckas 947a76c
remove extra file
ChrisRackauckas eb425a1
Adapt
ParamThakkar123 ba7d043
AutoAlgSwitch
ParamThakkar123 f123e4f
trivial_limiter!
ParamThakkar123 13a4150
AutoAlgSwitch
ParamThakkar123 9db7b75
Static
ParamThakkar123 4e32260
ADTypes
ParamThakkar123 41349aa
ADTypes
ParamThakkar123 e25583f
Tsit5ConstantCache
ParamThakkar123 1b8afa4
full_cache
ParamThakkar123 10a9a1e
norm
ParamThakkar123 b1ca7d8
full_cache
ParamThakkar123 984bce7
Update lib/OrdinaryDiffEqNordsieck/src/OrdinaryDiffEqNordsieck.jl
ChrisRackauckas 913b9ee
Update src/OrdinaryDiffEq.jl
ChrisRackauckas 032ee4d
a few more missing bits
ChrisRackauckas 1cf0be4
ODEIntegrator
ParamThakkar123 03093ac
perform_predict!
ParamThakkar123 0bb766e
full_cache
ParamThakkar123 439fad1
Fix prediction import
ChrisRackauckas b269441
add missing custom interpolations
ChrisRackauckas fc50277
DP8ConstantCache
ParamThakkar123 b1d993e
move high order interpolant
ChrisRackauckas b8a9bd3
a bit more
ChrisRackauckas 7fb1037
getting close
ChrisRackauckas a69313a
some imports
ChrisRackauckas 52d58bb
more
ChrisRackauckas 19423ae
one more
ChrisRackauckas c4d48f1
missing cache piece
ChrisRackauckas b3f2f3a
add missing cache
ChrisRackauckas 5d8b121
Update
ParamThakkar123 743eb97
Update
ParamThakkar123 9f452f2
Removed
ParamThakkar123 454389c
LinearAlgebra
ParamThakkar123 d125014
Revert "Merge remote-tracking branch 'origin/master'"
ChrisRackauckas b262540
Merge branch 'master' of https://github.com/ParamThakkar123/OrdinaryD…
ChrisRackauckas 6073819
FiniteDiff
ParamThakkar123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name = "OrdinaryDiffEqHighOrderRK" | ||
uuid = "d28bc4f8-55e1-4f49-af69-84c1a99f0f58" | ||
authors = ["ParamThakkar123 <[email protected]>"] | ||
version = "1.0.0" | ||
|
||
[deps] | ||
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed" | ||
MuladdMacro = "46d2c3a1-f734-5fdb-9937-b9b9aeba4221" | ||
RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd" | ||
FastBroadcast = "7034ab61-46d4-4ed7-9d0f-46aef9175898" | ||
|
||
[compat] | ||
julia = "1.10" | ||
|
||
[extras] | ||
DiffEqDevTools = "f3b72e0c-5b89-59e1-b016-84e28bfd966d" | ||
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" | ||
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f" | ||
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
||
[targets] | ||
test = ["DiffEqDevTools", "Random", "SafeTestsets", "Test"] |
22 changes: 22 additions & 0 deletions
22
lib/OrdinaryDiffEqHighOrderRK/src/OrdinaryDiffEqHighOrderRK.jl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
module OrdinaryDiffEqHighOrderRK | ||
|
||
import OrdinaryDiffEq: alg_order, qmax_default, qmin_default, beta2_default, beta1_default, | ||
explicit_rk_docstring, OrdinaryDiffEqAdaptiveAlgorithm, trivial_limiter!, | ||
_ode_addsteps!, @unpack, @cache, OrdinaryDiffEqMutableCache, constvalue, | ||
alg_cache, uses_uprev, initialize!, perform_step!, OrdinaryDiffEqConstantCache, | ||
calculate_residuals!, calculate_residuals | ||
import Static: False | ||
import MuladdMacro: @muladd | ||
import FastBroadcast: @.. | ||
import RecursiveArrayTools: recursivefill! | ||
|
||
include("algorithms.jl") | ||
include("alg_utils.jl") | ||
include("high_order_rk_caches.jl") | ||
include("high_order_rk_tableaus.jl") | ||
include("high_order_rk_addsteps.jl") | ||
include("high_order_rk_perform_step.jl") | ||
|
||
export TanYam7, DP8, PFRK87, TsitPap8 | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
alg_order(alg::TanYam7) = 7 | ||
alg_order(alg::DP8) = 8 | ||
alg_order(alg::TsitPap8) = 8 | ||
alg_order(alg::PFRK87) = 8 | ||
|
||
qmin_default(alg::DP8) = 1 // 3 | ||
|
||
qmax_default(alg::DP8) = 6 | ||
|
||
beta2_default(alg::DP8) = 0 // 1 | ||
|
||
beta1_default(alg::DP8, beta2) = typeof(beta2)(1 // alg_order(alg)) - beta2 / 5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
@doc explicit_rk_docstring( | ||
"Tanaka-Yamashita 7 Runge-Kutta method. (7th order interpolant).", | ||
"TanYam7", | ||
references = "Tanaka M., Muramatsu S., Yamashita S., (1992), On the Optimization of Some Nine-Stage | ||
Seventh-order Runge-Kutta Method, Information Processing Society of Japan, | ||
33 (12), pp. 1512-1526.") | ||
Base.@kwdef struct TanYam7{StageLimiter, StepLimiter, Thread} <: | ||
OrdinaryDiffEqAdaptiveAlgorithm | ||
stage_limiter!::StageLimiter = trivial_limiter! | ||
step_limiter!::StepLimiter = trivial_limiter! | ||
thread::Thread = False() | ||
end | ||
# for backwards compatibility | ||
function TanYam7(stage_limiter!, step_limiter! = trivial_limiter!) | ||
TanYam7(stage_limiter!, step_limiter!, False()) | ||
end | ||
|
||
@doc explicit_rk_docstring( | ||
"Hairer's 8/5/3 adaption of the Dormand-Prince Runge-Kutta method. (7th order interpolant).", | ||
"DP8", | ||
references = "E. Hairer, S.P. Norsett, G. Wanner, (1993) Solving Ordinary Differential Equations I. | ||
Nonstiff Problems. 2nd Edition. Springer Series in Computational Mathematics, | ||
Springer-Verlag.") | ||
Base.@kwdef struct DP8{StageLimiter, StepLimiter, Thread} <: OrdinaryDiffEqAdaptiveAlgorithm | ||
stage_limiter!::StageLimiter = trivial_limiter! | ||
step_limiter!::StepLimiter = trivial_limiter! | ||
thread::Thread = False() | ||
end | ||
# for backwards compatibility | ||
function DP8(stage_limiter!, step_limiter! = trivial_limiter!) | ||
DP8(stage_limiter!, step_limiter!, False()) | ||
end | ||
|
||
@doc explicit_rk_docstring("Phase-fitted Runge-Kutta of 8th order.", "PFRK87", | ||
extra_keyword_description = """- `omega`: a periodicity phase estimate, | ||
when accurate this method results in zero numerical dissipation. | ||
""", | ||
extra_keyword_default = "omega = 0.0") | ||
Base.@kwdef struct PFRK87{StageLimiter, StepLimiter, Thread, T} <: | ||
OrdinaryDiffEqAdaptiveAlgorithm | ||
stage_limiter!::StageLimiter = trivial_limiter! | ||
step_limiter!::StepLimiter = trivial_limiter! | ||
thread::Thread = False() | ||
omega::T = 0.0 | ||
end | ||
# for backwards compatibility | ||
function PFRK87(stage_limiter!, step_limiter! = trivial_limiter!; omega = 0.0) | ||
PFRK87(stage_limiter!, step_limiter!, False(), omega) | ||
end | ||
|
||
@doc explicit_rk_docstring("Tsitouras-Papakostas 8/7 Runge-Kutta method.", "TsitPap8") | ||
Base.@kwdef struct TsitPap8{StageLimiter, StepLimiter, Thread} <: | ||
OrdinaryDiffEqAdaptiveAlgorithm | ||
stage_limiter!::StageLimiter = trivial_limiter! | ||
step_limiter!::StepLimiter = trivial_limiter! | ||
thread::Thread = False() | ||
end | ||
# for backwards compatibility | ||
function TsitPap8(stage_limiter!, step_limiter! = trivial_limiter!) | ||
TsitPap8(stage_limiter!, step_limiter!, False()) | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -256,4 +256,4 @@ end | |
end | ||
end | ||
end | ||
=# | ||
=# |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1150,4 +1150,4 @@ end | |
f(k, u, p, t + dt) | ||
integrator.stats.nf += 1 | ||
return nothing | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name = "OrdinaryDiffEqLowOrderRK" | ||
uuid = "1344f307-1e59-4825-a18e-ace9aa3fa4c6" | ||
authors = ["ParamThakkar123 <[email protected]>"] | ||
version = "1.0.0" | ||
|
||
[deps] | ||
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed" | ||
MuladdMacro = "46d2c3a1-f734-5fdb-9937-b9b9aeba4221" | ||
RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd" | ||
FastBroadcast = "7034ab61-46d4-4ed7-9d0f-46aef9175898" | ||
|
||
[compat] | ||
julia = "1.10" | ||
|
||
[extras] | ||
DiffEqDevTools = "f3b72e0c-5b89-59e1-b016-84e28bfd966d" | ||
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" | ||
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f" | ||
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
||
[targets] | ||
test = ["DiffEqDevTools", "Random", "SafeTestsets", "Test"] |
30 changes: 30 additions & 0 deletions
30
lib/OrdinaryDiffEqLowOrderRK/src/OrdinaryDiffEqLowOrderRK.jl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
module OrdinaryDiffEqLowOrderRK | ||
|
||
import OrdinaryDiffEq: alg_order, isfsal, beta2_default, beta1_default, alg_stability_size, | ||
ssp_coefficient, OrdinaryDiffEqAlgorithm, OrdinaryDiffEqExponentialAlgorithm, | ||
explicit_rk_docstring, trivial_limiter!, OrdinaryDiffEqAdaptiveAlgorithm, | ||
unwrap_alg, @unpack, initialize!, perform_step!, calculate_residuals, | ||
calculate_residuals!, _ode_addsteps!, @OnDemandTableauExtract, constvalue, | ||
OrdinaryDiffEqMutableCache, uses_uprev, OrdinaryDiffEqConstantCache | ||
import DiffEqBase: @tight_loop_macros | ||
import MuladdMacro: @muladd | ||
import FastBroadcast: @.. | ||
import RecursiveArrayTools: recursivefill! | ||
|
||
include("algorithms.jl") | ||
include("alg_utils.jl") | ||
include("low_order_rk_caches.jl") | ||
include("low_order_rk_tableaus.jl") | ||
include("interp_func.jl") | ||
include("low_order_rk_perform_step.jl") | ||
include("low_order_rk_addsteps.jl") | ||
include("split_perform_step.jl") | ||
include("fixed_timestep_perform_step.jl") | ||
|
||
export Euler, SplitEuler, Heun, Ralston, Midpoint, RK4, | ||
BS3, OwrenZen3, OwrenZen4, OwrenZen5, BS5, Tsit5, | ||
DP5, Anas5, RKO65, FRK65, RKM, MSRK5, MSRK6, | ||
PSRK4p7q6, PSRK3p5q4, PSRK3p6q5, Stepanov5, SIR54, | ||
Alshina2, Alshina3, Alshina6 | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
alg_order(alg::Euler) = 1 | ||
alg_order(alg::SplitEuler) = 1 | ||
alg_order(alg::Heun) = 2 | ||
alg_order(alg::Ralston) = 2 | ||
alg_order(alg::Midpoint) = 2 | ||
alg_order(alg::BS3) = 3 | ||
alg_order(alg::OwrenZen3) = 3 | ||
alg_order(alg::BS5) = 5 | ||
alg_order(alg::OwrenZen4) = 4 | ||
alg_order(alg::OwrenZen5) = 5 | ||
alg_order(alg::Tsit5) = 5 | ||
alg_order(alg::DP5) = 5 | ||
alg_order(alg::Anas5) = 5 | ||
alg_order(alg::RKO65) = 5 | ||
alg_order(alg::FRK65) = 6 | ||
alg_order(alg::RK4) = 4 | ||
alg_order(alg::RKM) = 4 | ||
alg_order(alg::MSRK5) = 5 | ||
alg_order(alg::MSRK6) = 6 | ||
alg_order(alg::PSRK4p7q6) = 4 | ||
alg_order(alg::PSRK3p6q5) = 3 | ||
alg_order(alg::PSRK3p5q4) = 3 | ||
alg_order(alg::Stepanov5) = 5 | ||
alg_order(alg::SIR54) = 5 | ||
alg_order(alg::Alshina2) = 2 | ||
alg_order(alg::Alshina3) = 3 | ||
alg_order(alg::Alshina6) = 6 | ||
|
||
isfsal(alg::FRK65) = true | ||
isfsal(alg::RKO65) = false | ||
isfsal(alg::PSRK3p5q4) = false | ||
isfsal(alg::PSRK3p6q5) = false | ||
isfsal(alg::PSRK4p7q6) = false | ||
|
||
beta2_default(alg::DP5) = 4 // 100 | ||
|
||
beta1_default(alg::DP5, beta2) = typeof(beta2)(1 // alg_order(alg)) - 3beta2 / 4 | ||
|
||
alg_stability_size(alg::Tsit5) = 3.5068 | ||
alg_stability_size(alg::DP5) = 3.3066 | ||
|
||
ssp_coefficient(alg::Euler) = 1 | ||
|
||
function DiffEqBase.prepare_alg( | ||
alg::SplitEuler, | ||
u0::AbstractArray, | ||
p, prob) | ||
alg | ||
end |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will want to make Tsit5 be its own set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so for this I will make a separate OrdinaryDiffEqTsit inside lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OrdinaryDiffEqTsit5. Since it's the most common method and it's commonly used alone, making it as lean as possible is a virtue. Thanks.