Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Order Adaptivity to Radau #2478

Merged
merged 13 commits into from
Nov 10, 2024
Merged

Conversation

Shreyas-Ekanathan
Copy link
Contributor

@Shreyas-Ekanathan Shreyas-Ekanathan commented Sep 27, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

CompatHelper Julia and others added 8 commits September 20, 2024 12:33
@ChrisRackauckas
Copy link
Member

@AayushSabharwal

  LoadError: MethodError: no method matching SciMLBase.DynamicalODEFunction{false, SciMLBase.FullSpecialize, SciMLBase.ODEFunction{false, SciMLBase.FullSpecialize, typeof(Main.var"##Interpolation Output Type Tests#242".rlc1!), LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, typeof(SciMLBase.DEFAULT_OBSERVED), Nothing, Nothing, Nothing, Nothing}, SciMLBase.ODEFunction{false, SciMLBase.FullSpecialize, typeof(Main.var"##Interpolation Output Type Tests#242".identity_f), LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, typeof(SciMLBase.DEFAULT_OBSERVED), Nothing, Nothing, Nothing, Nothing}, LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, typeof(SciMLBase.DEFAULT_OBSERVED), Nothing, Nothing, Nothing}(::SciMLBase.ODEFunction{false, SciMLBase.FullSpecialize, typeof(Main.var"##Interpolation Output Type Tests#242".rlc1!), LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, typeof(SciMLBase.DEFAULT_OBSERVED), Nothing, Nothing, Nothing, Nothing}, ::SciMLBase.ODEFunction{false, SciMLBase.FullSpecialize, typeof(Main.var"##Interpolation Output Type Tests#242".identity_f), LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, typeof(SciMLBase.DEFAULT_OBSERVED), Nothing, Nothing, Nothing, Nothing}, ::LinearAlgebra.UniformScaling{Bool}, ::Nothing, ::Nothing, ::Nothing, ::Nothing, ::Nothing, ::Nothing, ::Nothing, ::Nothing, ::Nothing, ::Nothing, ::typeof(SciMLBase.DEFAULT_OBSERVED), ::Nothing, ::Nothing)
  
  Closest candidates are:
    (::Type{SciMLBase.DynamicalODEFunction{iip, specialize, F1, F2, TMM, Ta, Tt, TJ, JVP, VJP, JP, SP, TW, TWt, TPJ, O, TCV, SYS, ID}} where {iip, specialize, F1, F2, TMM, Ta, Tt, TJ, JVP, VJP, JP, SP, TW, TWt, TPJ, O, TCV, SYS, ID})(::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any)
     @ SciMLBase ~/.julia/packages/SciMLBase/t7Xn0/src/scimlfunctions.jl:641

looks like a you problem.

@ChrisRackauckas
Copy link
Member

@Shreyas-Ekanathan were those allocations we were discussing handled?

@ChrisRackauckas ChrisRackauckas merged commit f65bcca into SciML:master Nov 10, 2024
119 of 138 checks passed
@AayushSabharwal
Copy link
Member

SciML/SciMLBase.jl#856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants